Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release branch name collisions when releasing from multiple branches #719

Closed
chingor13 opened this issue Jan 22, 2021 · 1 comment · Fixed by #720
Closed

release branch name collisions when releasing from multiple branches #719

chingor13 opened this issue Jan 22, 2021 · 1 comment · Fixed by #720
Assignees
@chingor13
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chingor13
Copy link
Contributor

It's possible when releasing from multiple feature branches that release-please tries to use the same version. In this case, release-please would stomp on the other feature branches' release versions.

We probably need to construct a release branch naming structure such that they can never collide across branches.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 22, 2021
@chingor13 chingor13 self-assigned this Jan 22, 2021
@chingor13 chingor13 mentioned this issue Jan 26, 2021
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 27, 2021
@bcoe bcoe added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 29, 2021
@bcoe
Copy link
Contributor

bcoe commented Jan 29, 2021

Calling this a feature request, since it mainly crops up in the multiple release branch scenario, and we have work in motion to fix the problem.

@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jan 29, 2021
@bcoe bcoe closed this as completed in #720 Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: support stable release branch names chingor13/release-please
3 participants
@chingor13 @bcoe @yoshi-automation