Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): when tagging release, use updated, vs., created #708

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 15, 2021

There's a danger that someone comments on an old merged release PR, brining it earlier in chronological order, this would mean that we attempt to re-release the same version given how last release is calculated.

This is not a problem when tagging a release, which only occurs once after a PR is merged.

@bcoe bcoe requested a review from feywind January 15, 2021 23:56
@bcoe bcoe requested a review from a team as a code owner January 15, 2021 23:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #708 (670f0e4) into master (e0c7b00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   86.77%   86.78%           
=======================================
  Files          55       55           
  Lines        6579     6582    +3     
  Branches      616      586   -30     
=======================================
+ Hits         5709     5712    +3     
  Misses        869      869           
  Partials        1        1           
Impacted Files Coverage Δ
src/github-release.ts 96.17% <100.00%> (+0.03%) ⬆️
src/github.ts 83.70% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c7b00...670f0e4. Read the comment docs.

Copy link
Contributor

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To paraphrase Asimov, we had the answer that satisfied but now we have the answer that was true :D

@bcoe bcoe merged commit 9ae5620 into master Jan 16, 2021
@bcoe bcoe deleted the pagination-logic branch January 16, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants