fix(java): detect need for snapshot unless a snapshot is explicitly requested #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bcoe
approved these changes
Aug 12, 2020
JustinBeckwith
approved these changes
Aug 12, 2020
|
For the test that's failing, I don't think that condition is actually valid. If the repo needs a snapshot, we should propose the snapshot, otherwise the repo is blocked until someone (cron) explicitly asks for a snapshot. |
…a snapshot based on whether a snapshot is needed
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 81.66% 81.67% +0.01%
==========================================
Files 42 42
Lines 4973 4977 +4
Branches 400 401 +1
==========================================
+ Hits 4061 4065 +4
Misses 911 911
Partials 1 1
Continue to review full report at Codecov.
|
chingor13
changed the title
|
header-check is failing on the snapshot js files which are generated and will be stomped on |
|
@chingor13 does the config for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that snapshot is being explicitly set to false. This is preventing snapshots being created except when snapshot is explicitly being set to true. (Snapshots are only being created by the nightly cron bot job).