feat(java-yoshi): handle build.gradle and dependencies.properties files #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 79.95% 79.71% -0.25%
==========================================
Files 40 40
Lines 4595 4628 +33
Branches 346 374 +28
==========================================
+ Hits 3674 3689 +15
- Misses 920 938 +18
Partials 1 1
Continue to review full report at Codecov.
|
bcoe
approved these changes
Jun 11, 2020
jef
reviewed
Jun 12, 2020
| @@ -191,7 +192,13 @@ export class JavaYoshi extends ReleasePR { | |||
| }) | |||
| ); | |||
|
|
|||
| const pomFiles = await this.gh.findFilesByFilename('pom.xml'); | |||
| const pomFilesSearch = this.gh.findFilesByFilename('pom.xml'); | |||
| const buildFilesSearch = this.gh.findFilesByFilename('build.gradle'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow release-please to handle repos like gax-java and other gradle projects we manage