feat: a flag to skip CI #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 79.61% 79.88% +0.26%
==========================================
Files 40 40
Lines 4519 4578 +59
Branches 374 384 +10
==========================================
+ Hits 3598 3657 +59
Misses 920 920
Partials 1 1
Continue to review full report at Codecov.
|
bcoe
suggested changes
May 20, 2020
There was a problem hiding this comment.
I like this idea, but how do you feel about combining it with your initial idea of skipping all but the last commit if you don't do have CI turned on.
I think if we took this approach, I'd then feel safe turning this setting on by default in our cloud function that runs release-please.
|
@bcoe OK, so now:
|
bcoe
approved these changes
May 20, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [5.2.0](https://github.com/googleapis/release-please/compare/v5.1.0...v5.2.0) (2020-05-20) ### Features * a flag to skip CI ([#443](https://github.com/googleapis/release-please/issues/443)) ([17e0636](https://github.com/googleapis/release-please/commit/17e063656079c0f76dba7343f58f7595b132d7e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making assumptions such as "let's run / let's not run CI for the first / the last / whatever file", let's just make it configurable. I'm only using this flag in the simple releaser but any other releaser can be upgraded if needed. The default behavior is
skipCi: trueso nothing is changed for other releasers.