feat!: add autorelease: tagged label when creating GitHub release #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 85.53% 85.53%
=======================================
Files 25 25
Lines 2993 2993
Branches 263 263
=======================================
Hits 2560 2560
Misses 422 422
Partials 11 11Continue to review full report at Codecov.
|
chingor13
reviewed
Jan 2, 2020
bcoe
changed the title
chingor13
approved these changes
Jan 2, 2020
alexander-fenster
approved these changes
Jan 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: made
addLabelsAPI consistent withremoveLabels.The automation tool we use in conjunction with release-please,
autorelease, adds the tagautorelease: tagged, when a GitHub release has been created, but the package hasn't yet been published to a package registry.release-please now does the same; this will allow Node.js to continue using the same release monitoring helpers (which raise an alarm if a release failed) as we start moving towards a probot application for publishing to npm.