Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds additional updaters/logic for PHP mono-repo #195

Merged
merged 7 commits into from
Jun 20, 2019
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jun 20, 2019

Additional Updaters

  • PHPClientVersion: updates the const version in client libraries.
  • PHPManifest: adds new version to array in manifest.
  • RootComposer: adds updated version to root composer file.

TODO

  • tests need to be updated.

@bcoe bcoe requested a review from dwsupplee June 20, 2019 01:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #195 into master will increase coverage by 3.3%.
The diff coverage is 82.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #195     +/-   ##
=========================================
+ Coverage   69.32%   72.63%   +3.3%     
=========================================
  Files          12       15      +3     
  Lines        1842     2123    +281     
  Branches      157      182     +25     
=========================================
+ Hits         1277     1542    +265     
- Misses        555      571     +16     
  Partials       10       10
Impacted Files Coverage Δ
src/updaters/version.ts 95.23% <100%> (+0.11%) ⬆️
src/updaters/package-json.ts 95.65% <100%> (+0.09%) ⬆️
src/updaters/samples-package-json.ts 95.83% <100%> (+0.08%) ⬆️
src/updaters/changelog.ts 91.37% <100%> (-0.43%) ⬇️
src/github.ts 58.24% <33.33%> (+4.56%) ⬆️
src/github-release.ts 52.8% <50%> (-0.1%) ⬇️
src/updaters/php-manifest.ts 76.05% <76.05%> (ø)
src/updaters/root-composer.ts 83.87% <83.87%> (ø)
src/release-pr.ts 72.03% <87.15%> (+3.25%) ⬆️
src/updaters/php-client-version.ts 88.88% <88.88%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131752f...8bf831e. Read the comment docs.

@bcoe bcoe merged commit 728aa86 into master Jun 20, 2019
@bcoe bcoe deleted the php-finish-line branch June 20, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants