Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pull request files backfill optional #1147

Closed
chingor13 opened this issue Dec 20, 2021 · 0 comments · Fixed by #1151
Closed

Make pull request files backfill optional #1147

chingor13 opened this issue Dec 20, 2021 · 0 comments · Fixed by #1151
Labels
type: cleanup An internal cleanup or hygiene concern.
Milestone

Comments

@chingor13
Copy link
Contributor

When fetching the list of commits via GraphQL, we return the list of files touched in the commit. The list of files is only available if there is an associated pull request. We are currently always backfilling the list of commits via the REST API.

In many circumstances the list of files touched is not needed and thus we are potentially making a lot of unnecessary API calls. We should make the helper that fetches the list of commits accept an optional parameter to fill in the list of files touched.

@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Dec 20, 2021
@chingor13 chingor13 added this to the v13 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant