Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db_api): allow file path for credentials #221

Merged
merged 5 commits into from
Mar 10, 2021
Merged

fix(db_api): allow file path for credentials #221

merged 5 commits into from
Mar 10, 2021

Conversation

HemangChothani
Copy link
Contributor

Fixes #220

@HemangChothani HemangChothani requested review from larkee and c24t February 2, 2021 12:16
@HemangChothani HemangChothani requested a review from a team as a code owner February 2, 2021 12:16
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
@HemangChothani HemangChothani mentioned this pull request Feb 2, 2021
Closed
larkee
larkee reviewed Feb 8, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm a little concerned about having both a credentials and a credentials_uri kwarg for the same method. Did you consider any alternatives?

@HemangChothani
Copy link
Contributor Author

@larkee Yes i think, If we combine credentials and credentials_uri and make conditions on Object and string but it would be little bit confusing.
Need to change in doc of django_spanner accordingly.

larkee
larkee reviewed Feb 22, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor doc changes to try minimize confusion

google/cloud/spanner_dbapi/connection.py Outdated
@@ -356,7 +356,9 @@ def connect(
:type credentials: :class:`~google.auth.credentials.Credentials`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:type credentials: :class:`~google.auth.credentials.Credentials`
:type credentials: Union[:class:`~google.auth.credentials.Credentials`, str]

google/cloud/spanner_dbapi/connection.py Outdated
@@ -356,7 +356,9 @@ def connect(
:type credentials: :class:`~google.auth.credentials.Credentials`
:param credentials: (Optional) The authorization credentials to attach to
requests. These credentials identify this application
to the service. If none are specified, the client will
to the service. Or a string specifying (path) where to retrieve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

(Optional) The authorization credentials to attach to 
requests. These credentials identify this application 
to the service. These credentials may be specified as 
a file path indicating where to retrieve the service 
account JSON for the credentials to connect to 
Cloud Spanner. If none are specified, the client will 
attempt to ascertain the credentials from the 
environment.

@HemangChothani
Copy link
Contributor Author

System test failed with error google.api_core.exceptions.ResourceExhausted: 429 Project 1065521786570 cannot add 1 nodes in region us-central1. not related to changes.

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2021
@larkee larkee changed the title fix: credentials_uri parameter error fix(db_api): allow file path for credentials Mar 10, 2021
@larkee larkee merged commit 1de0284 into googleapis:master Mar 10, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 25, 2021
@release-please
chore: release 3.3.0 (#263)
6b517f2 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://github.com/googleapis/python-spanner/compare/v3.2.0...v3.3.0) (2021-03-25)


### Features

* add encryption_info to Database ([#284](https://github.com/googleapis/python-spanner/issues/284)) ([2fd0352](https://github.com/googleapis/python-spanner/commit/2fd0352f695d7ab85e57d8c4388f42f91cf39435))
* add support for CMEK ([#105](https://github.com/googleapis/python-spanner/issues/105)) ([e990ff7](https://github.com/googleapis/python-spanner/commit/e990ff70342e7c2e27059e82c8d74cce39eb85d0))
* add support for custom timeout and retry parameters in execute_update method in transactions ([#251](https://github.com/googleapis/python-spanner/issues/251)) ([8abaebd](https://github.com/googleapis/python-spanner/commit/8abaebd9edac198596e7bd51d068d50147d0391d))
* added retry and timeout params to partition read in database and snapshot class ([#278](https://github.com/googleapis/python-spanner/issues/278)) ([1a7c9d2](https://github.com/googleapis/python-spanner/commit/1a7c9d296c23dfa7be7b07ea511a4a8fc2c0693f))
* **db_api:** support executing several DDLs separated by semicolon ([#277](https://github.com/googleapis/python-spanner/issues/277)) ([801ddc8](https://github.com/googleapis/python-spanner/commit/801ddc87434ff9e3c86b1281ebfeac26195c06e8))


### Bug Fixes

* avoid consuming pending null values when merging ([#286](https://github.com/googleapis/python-spanner/issues/286)) ([c6cba9f](https://github.com/googleapis/python-spanner/commit/c6cba9fbe4c717f1f8e2a97e3f76bfe6b956e55b))
* **db_api:** allow file path for credentials ([#221](https://github.com/googleapis/python-spanner/issues/221)) ([1de0284](https://github.com/googleapis/python-spanner/commit/1de028430b779a50d38242fe70567e92b560df5a))
* **db_api:** ensure DDL statements are being executed ([#290](https://github.com/googleapis/python-spanner/issues/290)) ([baa02ee](https://github.com/googleapis/python-spanner/commit/baa02ee1a352f7c509a3e169927cf220913e521f))
* **db_api:** revert Mutations API usage ([#285](https://github.com/googleapis/python-spanner/issues/285)) ([e5d4901](https://github.com/googleapis/python-spanner/commit/e5d4901e9b7111b39dfec4c56032875dc7c6e74c))


### Documentation

* fix docstring types and typos ([#259](https://github.com/googleapis/python-spanner/issues/259)) ([1b0ce1d](https://github.com/googleapis/python-spanner/commit/1b0ce1d2986085ce4033cf773eb6c5d3b904473c))
* fix snapshot usage ([#291](https://github.com/googleapis/python-spanner/issues/291)) ([eee2181](https://github.com/googleapis/python-spanner/commit/eee218164c3177586b73278aa21495280984af89))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@c24t c24t Awaiting requested review from c24t

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner db_api: credentials_uri raise parameter error
3 participants
@HemangChothani @larkee @yoshi-kokoro