Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for instance labels #190

Closed
larkee opened this issue Dec 11, 2020 · 0 comments · Fixed by #193
Closed

Add support for instance labels #190

larkee opened this issue Dec 11, 2020 · 0 comments · Fixed by #193
Assignees
@larkee
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@larkee
Copy link
Contributor

larkee commented Dec 11, 2020

Cloud Spanner supports adding labels to resources such as instances which can be used for filtering. Currently, the Python library does not allow users to set or get the labels through the provided surface. Adding this support would allow instances created for running system tests to be labelled. This would allow instances from previous system test runs which were not deleted to be cleaned up as part of the testing setup.
@larkee larkee added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 11, 2020
@larkee larkee self-assigned this Dec 11, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Dec 11, 2020
This was referenced Dec 11, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larkee larkee

Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for instance labels larkee/python-spanner
1 participant
@larkee