Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Silence return_immediately flag Deprecation Warning #1066

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

mukund-ananthu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners January 29, 2024 20:26
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 29, 2024
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 29, 2024
@mukund-ananthu mukund-ananthu force-pushed the silenceWarning branch 2 times, most recently from 42fa3ba to 03e8ace Compare January 29, 2024 21:03
* Warning currently blocks #1064
* Silencing warning since it is expected
* Warning considered safe to ignore since tests are working as intended
@mukund-ananthu mukund-ananthu changed the title Silence Deprecation Warning test: Silence return_immediately flag Deprecation Warning Feb 2, 2024
@parthea parthea merged commit b4442c6 into main Feb 2, 2024
28 checks passed
@parthea parthea deleted the silenceWarning branch February 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants