-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update generated retry timings for publish and pull rpcs via synth #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Mar 4, 2020
busunkim96
reviewed
Mar 4, 2020
hongalex
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 10, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 10, 2020
hongalex
changed the title
[CHANGE ME] Re-generated to pick up changes in the API or client library generator.
fix: update generated retry timings for publish and pull rpcs (via synth)
Mar 12, 2020
hongalex
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 12, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 12, 2020
This was referenced Mar 23, 2020
In PR 53 I added a system test that will cover the fix for the DeadlineExceeded errors on synchronous pulls w/o published messages. Please review and merge that, too, once this one gets merged. |
hongalex
changed the title
fix: update generated retry timings for publish and pull rpcs (via synth)
fix: update generated retry timings for publish and pull rpcs via synth
Mar 23, 2020
hongalex
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 23, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 23, 2020
pradn
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/bcdace20-1a27-4371-afe0-2e371d8f7fd8/targets