Skip to content

Commit

Permalink
Remove LOGGER.exception() line
Browse files Browse the repository at this point in the history
* Information logged in this line will be available to the calling code
  via the exception thrown.
* There are scenarios where due to concurrency issues,  there are two uncoordinated outputs happening at once. This may result in this line logging stack traces after log statements in the exception block of the calling code.
  • Loading branch information
mukund-ananthu committed Feb 22, 2024
1 parent efbaf61 commit 792f86e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion google/cloud/pubsub_v1/publisher/_batch/thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ def _commit(self) -> None:
# Failed to publish batch.
self._batch_done_callback(batch_transport_succeeded)

_LOGGER.exception("Failed to publish %s messages.", len(self._futures))
return

end = time.time()
Expand Down

0 comments on commit 792f86e

Please sign in to comment.