Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support OpenTelemetry's LoggingInstrumentor #696

Open
daniel-sanche opened this issue Dec 14, 2022 · 2 comments
Open

feat: support OpenTelemetry's LoggingInstrumentor #696

daniel-sanche opened this issue Dec 14, 2022 · 2 comments
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daniel-sanche
Copy link
Contributor

OpenTelemetry libraries inject trace and span info into Python LogRecords. If we support these fields in this library, it would make our trace-log correlation feature work for frameworks outside of Flask/Django

#505 (comment)
@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 14, 2022
@daniel-sanche daniel-sanche self-assigned this Dec 14, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Dec 14, 2022
@Megabytemb
Copy link

Hey. Any movement on this feature?

It would be awesome to have correlated logs working right out of the box if you instrument with OpenTelemetry.
https://cloud.google.com/logging/docs/view/correlate-logs#view-correlated-log-entries

This also then has the added benefit of linking it into Cloud Trace as well.
Really seems like a good way to tie Google services together.

@meredithslota meredithslota mentioned this issue Aug 11, 2023
Closed
@daniel-sanche daniel-sanche removed their assignment Oct 20, 2023
@aradkdj
Copy link

aradkdj commented Sep 19, 2024

Unless I'm missing something this seems to be covered by #889

@aradkdj aradkdj mentioned this issue Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniel-sanche @Megabytemb @aradkdj