Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing for optional function parameters are incorrect #854

Closed
dcgudeman opened this issue Feb 21, 2024 · 2 comments
Closed

Typing for optional function parameters are incorrect #854

dcgudeman opened this issue Feb 21, 2024 · 2 comments
Assignees
@daniel-sanche
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Next Tasks

Comments

@dcgudeman
Copy link

dcgudeman commented Feb 21, 2024 •
edited
Loading

Environment details

  • OS type and version: MacOS
  • Python version: 3.11
  • pip version: 23.3.1
  • google-cloud-firestore version: 2.14.0

Steps to reproduce

  1. Use a function that has an optional parameter
  2. Observe type error

Code example

async_client = AsyncClient()
async_col_ref = async_client.collection("users")
all_users = async_col_ref.stream()

Stack trace

Argument of type "None" cannot be assigned to parameter "transaction" of type "Transaction" in function "stream"
  "None" is incompatible with "Transaction"Pylance[reportArgumentType](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportArgumentType)
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Feb 21, 2024
@dcgudeman dcgudeman mentioned this issue Feb 21, 2024
Closed
@daniel-sanche daniel-sanche added this to the Q2 milestone Feb 23, 2024
@daniel-sanche daniel-sanche self-assigned this Mar 19, 2024
@daniel-sanche daniel-sanche added priority: p3 Desirable enhancement or fix. May not be included in next release. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. labels Jun 17, 2024
@daniel-sanche
Copy link
Contributor

parent issue: #773

@daniel-sanche
Copy link
Contributor

This should be fixed in #984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Next Tasks
Development

Successfully merging a pull request may close this issue.

added the type 'Optional' to all optional parameters for async functions dcgudeman/python-firestore
2 participants
@daniel-sanche @dcgudeman