feat: Support the Count aggregation query #673
Conversation
product-auto-label
bot
added
size: xl
Mariatta
force-pushed
the
feat-aggregate-query
branch
from
023213f to
76a3690
Compare
| result = count_query.get() | ||
| assert len(result) == 1 | ||
| for r in result[0]: | ||
| assert r.alias == "total" |
There was a problem hiding this comment.
Looks great. Lines up with what I have here https://github.com/googleapis/python-firestore/pull/673/files.
tests/system/test_system.py
Outdated
| assert len(result[0]) == 2 | ||
|
|
||
| for r in result[0]: | ||
| assert r.alias in ["total", "all"] |
There was a problem hiding this comment.
Would it be more precise to do an assert check here that also verifies the order of "total" and "all" in r.alias? Perhaps two assert statements instead of using a loop?
There was a problem hiding this comment.
From my tests, the order of the result has been inconsistent. It doesn't always return it in the order of "total" and then "all".
I've now adjusted this test to assert that:
- there are two elements returned in the result
- the returned result has two values and they are both unique
- the result contains both aliases: "total" and "all"
Test in transaction
Mariatta
force-pushed
the
feat-aggregate-query
branch
from
29864f6 to
674d242
Compare
Refactor system test suite to fallback to default creds
Mariatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
| credentials = service_account.Credentials.from_service_account_file( | ||
| FIRESTORE_CREDS | ||
| ) | ||
| project = FIRESTORE_PROJECT or credentials.project_id | ||
| else: |
There was a problem hiding this comment.
would like someone from @googleapis/yoshi-python to take a look at this specifically
There was a problem hiding this comment.
@kolea2 did anyone from @googleapis/yoshi-python review this? I can't tell from the conversation.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕