Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): allow protobuf < 5.0.0 #624

Merged
merged 2 commits into from
Aug 11, 2022
Merged

fix(deps): allow protobuf < 5.0.0 #624

merged 2 commits into from
Aug 11, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 11, 2022

fix(deps): require proto-plus >= 1.22.0

@parthea parthea requested review from a team as code owners August 11, 2022 17:26
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Aug 11, 2022
unforced
unforced approved these changes Aug 11, 2022
View reviewed changes
Copy link

@unforced unforced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a foreign key error that needs resolved before this can be submitted.

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4baf837 into main Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the allow-protobuf-4 branch August 11, 2022 19:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unforced unforced unforced approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @unforced