fix: harden 'query.stream' against retriable exceptions #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
crwilcox
reviewed
Sep 23, 2021
google/cloud/firestore_v1/query.py
Outdated
|
|
||
| while True: | ||
| try: | ||
| response = next(response_iterator) |
There was a problem hiding this comment.
Could we inject this retry into __iter__ somehow? this seems more generally useful to me.
There was a problem hiding this comment.
Because the underlying API call is a unary_stream, the response_iterator is an instance of google.api_core.grpc_helpers._StreamingResponseIterator: I guess we could modify its __next__ to do something like this (it is already tweaked to cache the first result, for instance).
There was a problem hiding this comment.
I don't see how we get the applicable retry object inside there -- the _wrapped attribute isn't our _GapicCallable, but something altogether different.
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223.