-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for recursive queries #407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
crwilcox
reviewed
Aug 10, 2021
4637fdf
to
337932b
Compare
crwilcox
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: firestore
Issues related to the googleapis/python-firestore API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for queries to begin fetching all nested documents regardless of their collection name. Previously, the only similar mechanic available was the
all_descendants
parameter (available via thecollection_group
class), which is imperfectly named and in fact only fetches all descendants with the sameparent
name. So, for example:In this case, running
db.collection_group('users').get()
would fetch/users/alfred
and/users/alfred/users/alfreds-butler
, but NOT/users/alfred/pets/scruffy
.Not that this is decidedly not all of Alfred's descendants.
And thus: Recursive Queries ™️. Starting now, to fetch all three documents from the above hypothetical, a developer would run one of these two options: