Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: set retry to None in all gapics #807

Closed
daniel-sanche opened this issue Jun 21, 2023 · 1 comment
Closed

v3: set retry to None in all gapics #807

daniel-sanche opened this issue Jun 21, 2023 · 1 comment
Assignees
@daniel-sanche
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone
v3-alpha-2

Comments

@daniel-sanche
Copy link
Contributor

Gapic calls will automatically be wrapped with retry logic. We implement retries at a higher level. Make sure our hand-written layer disables gapic retries whenever it calls into the gapc layer

Currently only MutateRows actually has a default retry, but that could change going forward
@daniel-sanche daniel-sanche added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 21, 2023
@daniel-sanche daniel-sanche added this to the v3-alpha milestone Jun 21, 2023
@daniel-sanche daniel-sanche self-assigned this Jun 21, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 21, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-alpha, v3-beta Jun 29, 2023
@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 17, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-beta, v3-alpha-2 Sep 18, 2023
@mutianf
Copy link
Contributor

mutianf commented Oct 12, 2023

Estimate: 1 day

@daniel-sanche daniel-sanche mentioned this issue Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
v3-alpha-2
Development

No branches or pull requests
2 participants
@daniel-sanche @mutianf