Continuous test runs haven't succeeded since 15 September

[crwilcox]

b75b9d1...83958df

nox > * system_emulated: failed

____________________ ERROR at setup of test_table_read_row _____________________

admin_client = <google.cloud.bigtable.client.Client object at 0x7f95fe9e6d00>
data_instance_id = 'g-c-p-d-1631732911078'
instance_labels = {'python-system': '2021-09-15t19-08-31'}
data_cluster_id = 'g-c-p-d-1631732911078-cluster', location_id = 'us-central1-c'
serve_nodes = 3, in_emulator = True

    @pytest.fixture(scope="session")
    def data_instance_populated(
        admin_client,
        data_instance_id,
        instance_labels,
        data_cluster_id,
        location_id,
        serve_nodes,
        in_emulator,
    ):
        # Emulator does not support instance admin operations (create / delete).
        # See: https://cloud.google.com/bigtable/docs/emulator
        if not in_emulator:
            instance = admin_client.instance(data_instance_id, labels=instance_labels)
            cluster = instance.cluster(
                data_cluster_id, location_id=location_id, serve_nodes=serve_nodes,
            )
            operation = instance.create(clusters=[cluster])
            operation.result(timeout=30)
    
>       yield instance
E       UnboundLocalError: local variable 'instance' referenced before assignment

tests/system/conftest.py:159: UnboundLocalError

[tseaver]

@crwilcox Where are the test reports for those CI runs? If we could get #430 merged, we could see the emulator running in GH actions.

[tseaver]

E.g., this GH action shows the emulator tests passing.

[crwilcox]

@crwilcox Where are the test reports for those CI runs? If we could get #430 merged, we could see the emulator running in GH actions.

Unfortunately I am unsure if there is a non-google view. We have a dashboard of history of Kokoro runs accessible.

Those are only passing due to the changes on that PR. previously, a unbound local error would occur due to the way instances were created by a fixture. Also, some tests that cannot run against the emulator needed to be skipped. (#445)