fix: add minimum timeout to getQueryResults API requests #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since successful responses can still take a long time to download, have a minimum timeout which should accomodate 99.9%+ of responses. I figure it's more important that *any* timeout is set if desired than it is that the specific timeout is used. This is especially true in cases where a short timeout is requested for the purposes of a progress bar. Making forward progress is more important than the progress bar update frequency.
tswast
requested review from
a team and
shollyman
and removed request for
a team
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
shollyman
approved these changes
Jan 5, 2021
| @@ -3307,6 +3318,9 @@ def _list_rows_from_query_results( | |||
| "location": location, | |||
| } | |||
|
|
|||
| if timeout is not None: | |||
| timeout = max(timeout, _MIN_GET_QUERY_RESULTS_TIMEOUT) | |||
There was a problem hiding this comment.
Should we document this in the methods? e.g. timeout less than the _MIN_GET_QUERY_RESULTS_TIMEOUT are ignored?
shollyman
pushed a commit
to shollyman/python-bigquery
that referenced
this pull request
Feb 12, 2021
…rm/python-docs-samples#444) Put them in their own directory, since they duplicate the content from the existing samples that use the generated libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since successful responses can still take a long time to download, have
a minimum timeout which should accomodate 99.9%+ of responses.
I figure it's more important that any timeout is set if desired than
it is that the specific timeout is used. This is especially true in
cases where a short timeout is requested for the purposes of a progress
bar. Making forward progress is more important than the progress bar
update frequency.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #438 🦕