-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use debug logging level for OpenTelemetry message #442
Conversation
Updated based on apache/airflow#13131 to not warn at import time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the warning should not be issued at import time, but instead when trying to actually use BigQuery (discussion).
DEBUG level is probably indeed better, as opentelemetry
is not used by default (it's listed under extras), thus shouldn't bother users that don't choose to install it.
We should choose a different name for the flag, though, IMHO.
"add opentelemetry-api and opentelemetry-instrumentation " | ||
"packages in order to get BigQuery Tracing data." | ||
) | ||
WARNED_OPENTELEMETRY = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) It's a bit unexpected to change a "constant", perhaps rename it? Also, since it's an internal state-keeping flag that users should neither know about nor modify it, we should probably mark it as such (e.g. _warned_telemetry
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I've renamed in the latest commit.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #441 🦕