Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timestamp precision in insert_rows #393

Merged
merged 3 commits into from
Nov 23, 2020
Merged

fix: timestamp precision in insert_rows #393

merged 3 commits into from
Nov 23, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #392

@HemangChothani HemangChothani requested review from tswast and a team November 19, 2020 07:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 19, 2020
tswast
tswast requested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a system test for this. It'll need to query the table that rows are inserted into in order to ensure the values roundtrip correctly.

@tswast
Copy link
Contributor

tswast commented Nov 19, 2020

As my explorations showed in #392 (comment), we can format the date using YYYY-MM-DDTHH:MM:SS.MMMMMMZ instead of doing any sort of conversion to floating point.

tswast
tswast reviewed Nov 20, 2020
View reviewed changes
tests/unit/test__helpers.py Outdated

when = datetime.datetime(2016, 12, 20, 15, 58, 27, 339328)
self.assertEqual(self._call_fut(when), _microseconds_from_datetime(when) / 1e6)
self.assertEqual(self._call_fut(when), when.strftime(_RFC3339_MICROS))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these tests to compare against the actual string produced. I trust that when.strftime(_RFC3339_MICROS) is doing the right thing, but I'd be much more comfortable seeing the actual formatted string here and in the other unit tests.

@tswast tswast merged commit a1949ae into googleapis:master Nov 23, 2020
@zsolt-sb zsolt-sb mentioned this pull request Jan 19, 2021
Closed
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamp loss of precision in insert_rows
2 participants
@HemangChothani @tswast