Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests in client & job for Opentelemetry Instrumentation #221

Closed
aravinsiva opened this issue Aug 12, 2020 · 1 comment
Closed

Add tests in client & job for Opentelemetry Instrumentation #221

aravinsiva opened this issue Aug 12, 2020 · 1 comment
Assignees
@aravinsiva
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aravinsiva
Copy link
Contributor

In order to complete the instrumentation in modular stable PR's these tests are added separate from the PR with the instrumentation. Task it to add tests that assert the calling of the opentelemetry_tracing module when different API calls are made. These tests that need to be modified exist in the test_client.py module & test_job.py module.

Please assign to me
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 12, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 13, 2020
@meredithslota meredithslota added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Aug 13, 2020
@aravinsiva aravinsiva mentioned this issue Aug 16, 2020
Merged
@aravinsiva
Copy link
Contributor Author

Tests added in same PR as instrumentation.

@aravinsiva aravinsiva mentioned this issue Aug 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aravinsiva aravinsiva

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meredithslota @aravinsiva @yoshi-automation