Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove python 3.7 due to end of life (EOL) #737

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Conversation

chalmerlowe
Copy link
Collaborator

Removes support for Python 3.7 due to end of life (EOL)

@chalmerlowe chalmerlowe requested review from a team as code owners February 26, 2024 14:48
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Feb 26, 2024
@chalmerlowe chalmerlowe requested a review from parthea February 26, 2024 14:54
@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented Feb 26, 2024

@parthea

I seem to recall that there are some other steps in involved (was it something to do with pushing a CL to our internal repo?).

I attempted to create such a CL: cl/610397808, let me know if there is more that needs doing.

Any help you can offer is appreciated.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to remove python 3.7 in sync-repo-settings.yaml for both unit tests and samples

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the versions here :

ALL_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]

@parthea
Copy link
Contributor

parthea commented Feb 26, 2024

I just noticed that https://github.com/googleapis/python-bigquery-pandas/blob/main/testing/constraints-3.7.txt could be removed as well (and the contents moved to https://github.com/googleapis/python-bigquery-pandas/blob/main/testing/constraints-3.8.txt).

More information about the constraints files

Pip uses constraints files to add restrictions when resolving dependencies. In our case, we use constraints files to ensure that the lower bound that we advertise is actually checked in a test session. Some libraries also use constraints files to ensure that a wider range of dependency versions are covered across test sessions. Usually, lower bounds are checked in the lowest supported Python version. Constraints files are kept in sync manually with setup.py. If you forget to update the constraints file after updating a dependency's minimum version in setup.py, the test session fails with a constraints error.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 26, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2024
@chalmerlowe
Copy link
Collaborator Author

@parthea

Neither of the 3.7 tests is expected or needed to pass.
All other tests have passed.
Can you review and approve?

testing/constraints-3.8.txt Show resolved Hide resolved
testing/constraints-3.8.txt Outdated Show resolved Hide resolved
testing/constraints-3.8.txt Outdated Show resolved Hide resolved
@chalmerlowe chalmerlowe merged commit d0810e8 into main Feb 27, 2024
26 checks passed
@chalmerlowe chalmerlowe deleted the remove-python-3.7 branch February 27, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants