ENH: BQ Job Id in verbose output #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
===========================================
- Coverage 73.37% 28.21% -45.17%
===========================================
Files 4 4
Lines 1540 1542 +2
===========================================
- Hits 1130 435 -695
- Misses 410 1107 +697
Continue to review full report at Codecov.
|
tswast
approved these changes
Jul 10, 2017
|
can you add a note in the whatsnew (for 0.2.0)? otherwise lgtm. |
|
ok, here goes changelog entry |
parthea
reviewed
Jul 11, 2017
docs/source/changelog.rst
Outdated
| @@ -7,7 +7,8 @@ Changelog | |||
| - Drop support for Python 3.4 (:issue:`40`) | |||
| - The dataframe passed to ```.to_gbq(...., if_exists='append')``` needs to contain only a subset of the fields in the BigQuery schema. (:issue:`24`) | |||
| - Use the `google-auth <https://google-auth.readthedocs.io/en/latest/>`__ library for authentication because oauth2client is deprecated. (:issue:`39`) | |||
| - ``read_gbq`` now has a ``auth_local_webserver`` boolean argument for controlling whether to use web server or console flow when getting user credentials. Replaces `--noauth_local_webserver` command line argument (:issue:`35`) | |||
| - ``read_gbq`` now has a ``auth_local_webserver`` boolean argument for controlling whether to use web server or console flow when getting user credentials. Replaces `--noauth_local_webserver` command line argument. (:issue:`35`) | |||
| - read_gbq now displays the BigQuery Job ID in verbose output. (:issue:`70`) | |||
There was a problem hiding this comment.
Please can you add double back ticks around read_gbq? Otherwise, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After few years of BQ usage I've reached point where I need to report support case to Google BQ Team.
I've attached my iPython notebook with pandas gbq output, but they needed query Job IDs.
This is simple change to add them in read_gbq.
I'm not using to_gbq at all so I've not added verbose output for it when I implemented read_gbq some time ago. Today it is still not much verbose so I leaving things as they are.