Formatting with black #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Aug 29, 2018
tests/system/test_gbq.py
Outdated
| assert len(df.drop_duplicates()) == 10 | ||
|
|
||
| def test_standard_sql(self, project_id): | ||
| standard_sql = "SELECT DISTINCT id FROM " \ | ||
| "`publicdata.samples.wikipedia` LIMIT 10" | ||
| standard_sql = "SELECT DISTINCT id FROM " "`publicdata.samples.wikipedia` LIMIT 10" |
There was a problem hiding this comment.
E501 line too long (91 > 79 characters)
fixups and config
tswast
reviewed
Aug 29, 2018
There was a problem hiding this comment.
I'd be happy to update to this workflow and am okay with the one-time cost of a few (or a lot) of merge conflicts.
We could probably change the "lint" session in nox.py to run changes through black and complain if there's any diff afterward. That pattern is pretty common in Go projects I've worked on.
|
Sounds good to me. Thanks for adding this, @max-sixty ! |
|
@tswast please could you take a final look before I merge? I changed Stickler to use black rather than running in Travis on nox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example of how the repo would look using https://github.com/ambv/black
I find this great for repos I'm starting. I'm not sure it's worth the tradeoff of merge conflicts for existing projects, though.