BUG: fixed a bug that all TIMESTAMP fileds become 00 secconds. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
===========================================
- Coverage 75.5% 29.43% -46.08%
===========================================
Files 8 8
Lines 1535 1546 +11
===========================================
- Hits 1159 455 -704
- Misses 376 1091 +715
Continue to review full report at Codecov.
|
|
This looks great! Thank you. Could you add a short test? |
rhoboro
force-pushed
the
exact_timestamp
branch
from
aba23d0 to
69147dd
Compare
max-sixty
reviewed
Mar 13, 2018
pandas_gbq/tests/test_gbq.py
Outdated
| test_size = 6 | ||
| df = DataFrame(np.random.randn(test_size, 4), index=range(test_size), | ||
| columns=list('ABCD')) | ||
| test_timestamp = datetime.now(pytz.timezone('UTC')) |
There was a problem hiding this comment.
Ideally this would be a value rather than .now, and that's harder to reproduce, but not a huge issue
There was a problem hiding this comment.
Thank you for your review. I fixed this.
05ac27b
|
Integration tests pass: https://travis-ci.org/maxim-lian/pandas-gbq/builds/352690707 |
tswast
approved these changes
Mar 13, 2018
|
@maxim-lian @rhoboro Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that all TIMESTAMP fileds become 00 secconds in BigQuery.
#69 (comment) mentions to same issue.