fix: memory leak in bidi classes #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
commented
Dec 16, 2024
| @@ -717,6 +719,7 @@ def stop(self): | |||
| _LOGGER.warning("Background thread did not exit.") | |||
|
|
|||
| self._thread = None | |||
| self._on_response = None | |||
There was a problem hiding this comment.
This assumes you can't restart an instance after it has been stopped. The test cases and docstrings point to that being the case, but it's not completely clear
There was a problem hiding this comment.
I think this is a reasonable assumption given that resources should be cleaned up when close is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.
parthea
approved these changes
Jan 22, 2025
| @@ -717,6 +719,7 @@ def stop(self): | |||
| _LOGGER.warning("Background thread did not exit.") | |||
|
|
|||
| self._thread = None | |||
| self._on_response = None | |||
There was a problem hiding this comment.
I think this is a reasonable assumption given that resources should be cleaned up when close is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.
|
Thanks @daniel-sanche ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769