Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update OperationsAsyncClient to use AsyncRetry #544

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: update OperationsAsyncClient to use AsyncRetry #544

merged 1 commit into from
Nov 8, 2023

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Oct 30, 2023 •
edited
Loading

@ohmayr ohmayr requested review from a team as code owners October 30, 2023 02:01
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 30, 2023
vchudnov-g
vchudnov-g approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest updating the the PR title to read "update OperationsAsyncClient to use AsyncRetry" (I mention this becase simply "client" makes me think of the generator, not core).

Otherwise LGTM. Thanks for dong this!

@ohmayr ohmayr changed the title fix: update async client to use async retry fix: update OperationsAsyncClient to use AsyncRetry Nov 3, 2023
@parthea parthea merged commit f21bb32 into main Nov 8, 2023
@parthea parthea deleted the update-async-client-to-use-async-retry branch November 8, 2023 17:00
@release-please release-please bot mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async clients do not document and implement retries correctly (and hence retries don't work)
3 participants
@ohmayr @vchudnov-g @parthea