Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/python-api-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.19.0
Choose a base ref
...
head repository: googleapis/python-api-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.19.1
Choose a head ref
  • 9 commits
  • 14 files changed
  • 6 contributors

Commits on May 3, 2024

  1. chore: avoid checking instance on each stream call (#529)

    * chore: avoid checking instance on each stream call
    
    * fixed indentation
    
    * added check for unary call
    
    * fixed type check
    
    * fixed tests
    
    * fixed coverage
    
    * added exception to test class
    
    * added comment to test
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    daniel-sanche and gcf-owl-bot[bot] authored May 3, 2024
    Configuration menu
    Copy the full SHA
    ab22afd View commit details
    Browse the repository at this point in the history
  2. feat: add caching to GapicCallable (#527)

    * feat: optimize _GapicCallable
    
    * cleaned up metadata lines
    
    * chore: avoid type checks in error wrapper
    
    * Revert "chore: avoid type checks in error wrapper"
    
    This reverts commit c97a636.
    
    * add default wrapped function
    
    * fixed decorator order
    
    * fixed spacing
    
    * fixed comment typo
    
    * fixed spacing
    
    * fixed spacing
    
    * removed unneeded helpers
    
    * use caching
    
    * improved metadata parsing
    
    * improved docstring
    
    * fixed logic
    
    * added benchmark test
    
    * update threshold
    
    * run benchmark in loop for testing
    
    * use verbose logs
    
    * Revert testing
    
    * used smaller value
    
    * changed threshold
    
    * removed link in comment
    daniel-sanche authored May 3, 2024
    Configuration menu
    Copy the full SHA
    d96eb5c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. chore: fallback to unary_unary when wrapping async callables (#653)

    * fix: fallback to unary_unary when wrapping async callables
    
    We recently [made a change](ab22afd) to move some computation in the async rpc wrapper from call-time to wrap-time. This way, individual calls would execute faster, since they don't have to re-compute some data on each call
    
    A side-effect of this change is that now some [type validation](https://github.com/googleapis/python-api-core/blob/d96eb5cdd8120bfec97d62b09512c6fecc325be8/google/api_core/grpc_helpers_async.py#L209) happens earlier. This caused some downstream tests to fail when a mock grpc channel is used. The wrapper doesn't know how to handle the mock.Mock type, and raises an exception while constructing the client object
    
    This PR fixes the issue by falling back to the unary wrapper when the callable type is unknown, rather than raising an exception. This is in-line with how [the sync version handles it](https://github.com/googleapis/python-api-core/blob/d96eb5cdd8120bfec97d62b09512c6fecc325be8/google/api_core/grpc_helpers.py#L198)
    
    * fixed elif to if
    
    * removed outdated test
    daniel-sanche authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c9e1cbb View commit details
    Browse the repository at this point in the history
  2. fix: Ignore unknown fields in rest streaming. (#651)

    * Ignore unknown fields in rest streaming.
    
    If the api adds a new field to a stremaing response, it shouldn't break old clients.
    
    We found this in the google.ai.generativelanguage API. Colab forces our clients to use rest, so all our streaming examples broke when the API team rolled out a new field.
    
    * format
    
    ---------
    
    Co-authored-by: Anthonios Partheniou <[email protected]>
    MarkDaoust and parthea authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1203fb9 View commit details
    Browse the repository at this point in the history
  3. chore: move retry async check to wrap time (#649)

    * chore: move retry async check to wrap time
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * added no cover mark
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: Anthonios Partheniou <[email protected]>
    3 people authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ac098a7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e031eb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    126b5c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. fix: add support for protobuf 5.x (#644)

    * fix: add support for protobuf 5.x
    
    * remove pin for types-protobuf
    
    * remove pytest from noxfile
    
    * refactor common code
    
    * Refactor
    
    Co-authored-by: Victor Chudnovsky <[email protected]>
    
    * run black
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * mypy
    
    * run pre-release test against all python versions
    
    * filter warning
    
    ---------
    
    Co-authored-by: Victor Chudnovsky <[email protected]>
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    3 people authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    fda0ca6 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. chore(main): release 2.19.1 (#650)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fef9363 View commit details
    Browse the repository at this point in the history
Loading