-
Notifications
You must be signed in to change notification settings - Fork 93
fix: move region tag to encompass catch #320
Conversation
ping me for buganizer bug if you want |
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 52.78% 52.78%
=======================================
Files 7 7
Lines 1508 1508
Branches 53 53
=======================================
Hits 796 796
Misses 710 710
Partials 2 2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've usually kept the main().catch(console.error);
out of the samples, I think if we moved to @fhinkel's suggestion of having an inner async
function, so that async/await
works as expected in samples, it would eliminate this need -- we'd then move the region tag inside the outer main
method.
I'll make that change and update the PR accordingly |
…js-text-to-speech into fix_quickstart_regiontag
I have no idea how a bunch of stuff became lowercase but I'll revert all of those things now |
No description provided.