From c3005691b0721dfbd29d2793ceffba98aef20a83 Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Sat, 27 Aug 2022 05:04:30 +0000 Subject: [PATCH] fix: do not import the whole google-gax from proto JS (#1553) (#923) fix: use google-gax v3.3.0 Source-Link: https://github.com/googleapis/synthtool/commit/c73d112a11a1f1a93efa67c50495c19aa3a88910 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e --- .github/.OwlBot.lock.yaml | 4 ++-- package.json | 2 +- protos/protos.d.ts | 2 +- protos/protos.js | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 74883698..4d586c42 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,5 +13,5 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest - digest: sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15 -# created: 2022-08-23T18:40:55.597313991Z + digest: sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e +# created: 2022-08-26T22:34:55.905845397Z diff --git a/package.json b/package.json index 4c471f83..52b8538d 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "dependencies": { "@google-cloud/common": "^4.0.0", "@types/pumpify": "^1.4.1", - "google-gax": "^3.1.2", + "google-gax": "^3.3.0", "pumpify": "^2.0.0", "stream-events": "^1.0.4", "uuid": "^8.3.2" diff --git a/protos/protos.d.ts b/protos/protos.d.ts index ce58a147..d732893b 100644 --- a/protos/protos.d.ts +++ b/protos/protos.d.ts @@ -13,7 +13,7 @@ // limitations under the License. import Long = require("long"); -import {protobuf as $protobuf} from "google-gax"; +import type {protobuf as $protobuf} from "google-gax"; /** Namespace google. */ export namespace google { diff --git a/protos/protos.js b/protos/protos.js index c02102d1..aa6127df 100644 --- a/protos/protos.js +++ b/protos/protos.js @@ -19,7 +19,7 @@ define(["protobufjs/minimal"], factory); /* CommonJS */ else if (typeof require === 'function' && typeof module === 'object' && module && module.exports) - module.exports = factory(require("google-gax").protobufMinimal); + module.exports = factory(require("google-gax/build/src/protobuf").protobufMinimal); })(this, function($protobuf) { "use strict";