Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check status of long running operation by its name #937

Merged
merged 2 commits into from
May 6, 2020

Conversation

alexander-fenster
Copy link
Contributor

For each client method returning a long running operation, a separate method to check its status is added.

Added methods: checkCreateBackupProgress, checkCreateDatabaseProgress, checkCreateInstanceProgress, checkRestoreDatabaseProgress, checkUpdateDatabaseDdlProgress, checkUpdateInstanceProgress.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #937 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   98.18%   98.25%   +0.06%     
==========================================
  Files          21       21              
  Lines       19743    19947     +204     
  Branches     1057      951     -106     
==========================================
+ Hits        19385    19599     +214     
+ Misses        354      346       -8     
+ Partials        4        2       -2     
Impacted Files Coverage Δ
src/v1/database_admin_client.ts 99.47% <100.00%> (+0.02%) ⬆️
src/v1/instance_admin_client.ts 99.09% <100.00%> (+0.03%) ⬆️
src/backup.ts 99.39% <0.00%> (-0.01%) ⬇️
src/database.ts 99.91% <0.00%> (-0.01%) ⬇️
src/index.ts 100.00% <0.00%> (ø)
src/common.ts 0.00% <0.00%> (ø)
bin/benchwrapper.js 0.00% <0.00%> (ø)
src/instance.ts 99.61% <0.00%> (+<0.01%) ⬆️
src/transaction-runner.ts 99.15% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72e7de...3667375. Read the comment docs.

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

For each client method returning a long running operation, a separate method to check its status is added.

Added methods: `checkCreateBackupProgress`, `checkCreateDatabaseProgress`, `checkCreateInstanceProgress`, `checkRestoreDatabaseProgress`, `checkUpdateDatabaseDdlProgress`, `checkUpdateInstanceProgress`.
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5035e11 into master May 6, 2020
@alexander-fenster alexander-fenster deleted the get-lro-status branch May 6, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants