fix: use PreciseDate instead of Date for min read timestamp #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
agasheesh
force-pushed
the
master
branch
2 times, most recently
from
021a6f9 to
6893906
Compare
Codecov Report
@@ Coverage Diff @@
## master #807 +/- ##
=========================================
Coverage ? 76.06%
=========================================
Files ? 43
Lines ? 20272
Branches ? 561
=========================================
Hits ? 15419
Misses ? 4847
Partials ? 6
Continue to review full report at Codecov.
|
skuruppu
reviewed
Jan 23, 2020
skuruppu
approved these changes
Jan 24, 2020
agasheesh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, TimestampBounds defaults min read timestamp to empty google timestamp proto, which correspond to min unix time i.e., 1970:01:01-T:00:00:00Z.