fix: createInstance should return a value #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createInstance() method should return a value to allow promise chaining. Fixes googleapis#746.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 96.11% 96.11% +<.01%
==========================================
Files 18 18
Lines 15617 15618 +1
Branches 532 532
==========================================
+ Hits 15010 15011 +1
Misses 602 602
Partials 5 5
Continue to review full report at Codecov.
|
callmehiphop
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createInstance() method should return a value to allow promise chaining.
Fixes #746.