-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't wrap SpannerDate so timezone does not affect results #711
fix: don't wrap SpannerDate so timezone does not affect results #711
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 15 15
Lines 1648 1648
Branches 278 278
=======================================
Hits 1612 1612
Misses 19 19
Partials 17 17 Continue to review full report at Codecov.
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@prunge-helix thanks for the patch 😄 I think this would be a breaking change, so we need to be a bit careful pulling it in. I've looped in @stephenplusplus and @callmehiphop who know more about @google-cloud/spanner than myself. |
@bcoe why would this be a breaking change? It looks like it is just a fix for a sample |
@callmehiphop @prunge-helix my bad, I didn't notice it was a sample file changing 😄 please go ahead and land. |
This change allows the
should use an ARRAY query parameter to query record from the Venues example table
test to pass when run on machines with time zones with positive offsets.Fixes #710