Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't wrap SpannerDate so timezone does not affect results #711

Merged

Conversation

prunge-helix
Copy link
Contributor

This change allows the should use an ARRAY query parameter to query record from the Venues example table test to pass when run on machines with time zones with positive offsets.

Fixes #710

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          15       15           
  Lines        1648     1648           
  Branches      278      278           
=======================================
  Hits         1612     1612           
  Misses         19       19           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03384d4...306b118. Read the comment docs.

@prunge-helix
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 21, 2019
@bcoe
Copy link
Contributor

bcoe commented Oct 22, 2019

@prunge-helix thanks for the patch 😄

I think this would be a breaking change, so we need to be a bit careful pulling it in. I've looped in @stephenplusplus and @callmehiphop who know more about @google-cloud/spanner than myself.

@callmehiphop
Copy link
Contributor

@bcoe why would this be a breaking change? It looks like it is just a fix for a sample

@bcoe
Copy link
Contributor

bcoe commented Oct 24, 2019

@callmehiphop @prunge-helix my bad, I didn't notice it was a sample file changing 😄

please go ahead and land.

@callmehiphop callmehiphop merged commit 86c0ae5 into googleapis:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples-test - ARRAY query parameter - failing for timezone with positive offset
4 participants