Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): batch create sessions #692

Merged
merged 21 commits into from
Nov 5, 2019
Merged

feat(database): batch create sessions #692

merged 21 commits into from
Nov 5, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Sep 17, 2019

There's a decrease in code coverage, however I believe this feature is tested at 100%.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
@kolea2 kolea2 requested a review from skuruppu September 17, 2019 20:49
@callmehiphop callmehiphop requested a review from jkwlui September 23, 2019 21:48
src/session-pool.ts Outdated Show resolved Hide resolved
src/session-pool.ts Outdated Show resolved Hide resolved
src/session-pool.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #692 into master will increase coverage by 0.02%.
The diff coverage is 99.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   96.09%   96.12%   +0.02%     
==========================================
  Files          18       18              
  Lines       15483    15607     +124     
  Branches      528      532       +4     
==========================================
+ Hits        14879    15002     +123     
  Misses        600      600              
- Partials        4        5       +1
Impacted Files Coverage Δ
src/session-pool.ts 99.2% <100%> (ø) ⬆️
src/database.ts 99.81% <99.15%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7075e3...9abd3f4. Read the comment docs.

@callmehiphop callmehiphop marked this pull request as ready for review September 26, 2019 20:05
@callmehiphop callmehiphop requested a review from a team September 26, 2019 23:53
@bcoe
Copy link
Contributor

bcoe commented Sep 27, 2019

@callmehiphop I believe the decrease in coverage is related to a slight bug with default parameters showing up as uncovered.

I wouldn't worry about such a small drop in coverage.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2019
proto/spanner.d.ts Show resolved Hide resolved
src/database.ts Outdated Show resolved Hide resolved
src/database.ts Outdated Show resolved Hide resolved
@bcoe
Copy link
Contributor

bcoe commented Oct 10, 2019

don't have a super strong opinion on this feature, going to leave it to @jkwlui, @crwilcox, and company to chime in.

Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for the logic in the PR. I will leave it up to repo owners to approve on the Node.js specifics.

@crwilcox
Copy link
Contributor

@callmehiphop it seems some files are missing license headers?

@callmehiphop
Copy link
Contributor Author

@crwilcox yep, but the file in question is generated so while I could add them, they're likely to magically disappear in the future. @bcoe @alexander-fenster any way around this?

@bcoe
Copy link
Contributor

bcoe commented Oct 28, 2019

I don't think we should block merging on license headers for generated code, but we've discussed this in chat with @alexander-fenster (and I'm hoping we'll start populating headers appropriately soon).

@callmehiphop
Copy link
Contributor Author

@bcoe SGTM.

@crwilcox did you have a chance to review this before I merge?

src/session-pool.ts Show resolved Hide resolved
@skuruppu skuruppu merged commit 21f83b1 into googleapis:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants