-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(database): batch create sessions #692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 96.09% 96.12% +0.02%
==========================================
Files 18 18
Lines 15483 15607 +124
Branches 528 532 +4
==========================================
+ Hits 14879 15002 +123
Misses 600 600
- Partials 4 5 +1
Continue to review full report at Codecov.
|
@callmehiphop I believe the decrease in coverage is related to a slight bug with default parameters showing up as uncovered. I wouldn't worry about such a small drop in coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval for the logic in the PR. I will leave it up to repo owners to approve on the Node.js specifics.
@callmehiphop it seems some files are missing license headers? |
@crwilcox yep, but the file in question is generated so while I could add them, they're likely to magically disappear in the future. @bcoe @alexander-fenster any way around this? |
I don't think we should block merging on license headers for generated code, but we've discussed this in chat with @alexander-fenster (and I'm hoping we'll start populating headers appropriately soon). |
There's a decrease in code coverage, however I believe this feature is tested at 100%.