Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency p-queue to v5 #578

Merged
merged 3 commits into from
May 7, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 6, 2019

This PR contains the following updates:

Package Type Update Change References
p-queue dependencies major ^4.0.0 -> ^5.0.0 source

Release Notes

sindresorhus/p-queue

v5.0.0

Compare Source

Breaking:

  • Require Node.js 8 7ce42b3
  • For TypeScript users only:
    • Refactor TypeScript definition to CommonJS compatible export 11a0807
      • You need to change import pQueue from 'p-queue'; to import pQueue = require('p-queue');

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2019
@JustinBeckwith JustinBeckwith added the status: blocked Resolving the issue is dependent on other work. label Apr 7, 2019
@renovate renovate bot force-pushed the renovate/p-queue-5.x branch from c45b633 to 7a7171f Compare April 7, 2019 01:24
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 11, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Apr 11, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2019
@bcoe bcoe removed the status: blocked Resolving the issue is dependent on other work. label May 7, 2019
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #578 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          11       11           
  Lines        1355     1355           
  Branches      204      204           
=======================================
  Hits         1344     1344           
  Misses          2        2           
  Partials        9        9
Impacted Files Coverage Δ
src/session-pool.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb2255...cae9271. Read the comment docs.

@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 7, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 7, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2019
@JustinBeckwith JustinBeckwith merged commit 7827fb4 into master May 7, 2019
@renovate renovate bot deleted the renovate/p-queue-5.x branch May 7, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants