Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support customer managed instance configurations #1611

Merged
merged 43 commits into from
Sep 29, 2022
Merged

feat: support customer managed instance configurations #1611

merged 43 commits into from
Sep 29, 2022

Conversation

rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Apr 18, 2022 •
edited
Loading

This PR implements the functionality for CMMR Phase 2. Ir provides the following features:

  • Create, update, delete user managed instance config.
  • Ability to list InstanceConfig operations (currently CreateInstanceConfig operations).

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Apr 18, 2022
@rajatbhatta rajatbhatta force-pushed the cmmr-phase-2 branch 3 times, most recently from 60bd40f to 71e76b0 Compare April 19, 2022 11:35
@rajatbhatta rajatbhatta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2022
@rajatbhatta rajatbhatta marked this pull request as ready for review April 20, 2022 05:21
@rajatbhatta rajatbhatta requested review from a team as code owners April 20, 2022 05:21
@rajatbhatta rajatbhatta requested a review from olavloite April 20, 2022 05:22
@rajatbhatta rajatbhatta mentioned this pull request Apr 20, 2022
Closed
olavloite
olavloite reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some end-to-end tests for this?

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/instance-config.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/instance-config.ts Outdated Show resolved Hide resolved
src/instance-config.ts Show resolved Hide resolved
src/instance-config.ts Outdated Show resolved Hide resolved
rajatbhatta and others added 5 commits April 21, 2022 12:00
@rajatbhatta @olavloite
Update src/index.ts
2d71703 
Co-authored-by: Knut Olav Løite <[email protected]>
@rajatbhatta @olavloite
Update src/index.ts
8fafeab 
Co-authored-by: Knut Olav Løite <[email protected]>
@rajatbhatta @olavloite
Update src/instance-config.ts
cc7a5bf 
Co-authored-by: Knut Olav Løite <[email protected]>
@rajatbhatta @olavloite
Update src/instance-config.ts
28435aa 
Co-authored-by: Knut Olav Løite <[email protected]>
@rajatbhatta @olavloite
Update src/index.ts
ae320c5 
Co-authored-by: Knut Olav Løite <[email protected]>
@rajatbhatta
Copy link
Contributor Author

Can we add some end-to-end tests for this?

@olavloite: Yes, I'm working on a separate PR(in draft phase) for adding tests.

@rajatbhatta rajatbhatta requested a review from olavloite April 25, 2022 05:05
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@rajatbhatta rajatbhatta changed the title feat: [DO NOT MERGE] support customer managed instance configurations feat: support customer managed instance configurations Sep 29, 2022
@rajatbhatta rajatbhatta added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@rajatbhatta rajatbhatta merged commit bbe8f69 into googleapis:main Sep 29, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2022
@release-please release-please bot mentioned this pull request Sep 29, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 17, 2022
@release-please
chore(main): release 6.3.0 (#1719)
ee12356 
🤖 I have created a release *beep* *boop*
---


## [6.3.0](https://github.com/googleapis/nodejs-spanner/compare/v6.2.0...v6.3.0) (2022-10-03)


### Features

* Support customer managed instance configurations ([#1611](https://github.com/googleapis/nodejs-spanner/issues/1611)) ([bbe8f69](https://github.com/googleapis/nodejs-spanner/commit/bbe8f697e8838e358973cd4a5f2db9e2d4df5349))


### Bug Fixes

* **deps:** Update dependency @google-cloud/precise-date to v3 ([#1676](https://github.com/googleapis/nodejs-spanner/issues/1676)) ([3f20ec4](https://github.com/googleapis/nodejs-spanner/commit/3f20ec47bbf89e1f72546a8ebf41a8b4ba93832f))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-spanner/issues/1553)) ([#1700](https://github.com/googleapis/nodejs-spanner/issues/1700)) ([f9c2640](https://github.com/googleapis/nodejs-spanner/commit/f9c2640e054659a2e8299b8f989fa7936d04b0d7))
* use google-gax v3.3.0 ([f9c2640](https://github.com/googleapis/nodejs-spanner/commit/f9c2640e054659a2e8299b8f989fa7936d04b0d7))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajatbhatta @olavloite @yoshi-kokoro