Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Point In Time Recovery (PITR) #1250

Merged
merged 7 commits into from
Feb 19, 2021
Merged

feat: Point In Time Recovery (PITR) #1250

merged 7 commits into from
Feb 19, 2021

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Oct 7, 2020 •
edited
Loading

No description provided.

@skuruppu skuruppu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 7, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #1250 (4551956) into master (6625ef2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1250   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          23       23           
  Lines       21688    21698   +10     
  Branches     1219     1220    +1     
=======================================
+ Hits        21382    21392   +10     
  Misses        297      297           
  Partials        9        9
Impacted Files Coverage Δ
src/backup.ts 99.81% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6625ef2...cbecb88. Read the comment docs.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Oct 11, 2020
@skuruppu skuruppu force-pushed the pitr-lite-support branch 2 times, most recently from 5da9237 to c0e6b55 Compare October 15, 2020 05:01
@skuruppu skuruppu marked this pull request as ready for review October 15, 2020 05:03
@skuruppu skuruppu requested review from a team as code owners October 15, 2020 05:03
thiagotnunes
thiagotnunes approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snippet-bot
Copy link

snippet-bot bot commented Dec 4, 2020 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@skuruppu skuruppu force-pushed the pitr-lite-support branch 2 times, most recently from a651742 to 81b4585 Compare February 2, 2021 04:30
@skuruppu skuruppu changed the title feat: PiTR-lite support feat: Point In Time Recovery (PITR) Feb 2, 2021
@skuruppu
Copy link
Contributor Author

skuruppu commented Feb 2, 2021

PTAL @thiagotnunes, I updated the backup/restore samples to include version_time.

thiagotnunes
thiagotnunes approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skuruppu skuruppu removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 4, 2021
skuruppu
skuruppu commented Feb 5, 2021
View reviewed changes
src/backup.ts Outdated Show resolved Hide resolved
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Feb 19, 2021
@skuruppu skuruppu merged commit c53f677 into googleapis:master Feb 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skuruppu @thiagotnunes @olavloite