Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(samples-test): race condition in deleteData sample #1156

Merged
merged 2 commits into from
Jun 18, 2020
Merged

fix(samples-test): race condition in deleteData sample #1156

merged 2 commits into from
Jun 18, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Jun 18, 2020 •
edited by skuruppu
Loading

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1099, #1147, #1095

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #1156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          21       21           
  Lines       20925    20925           
  Branches     1153     1153           
=======================================
  Hits        20579    20579           
  Misses        343      343           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b935a...6928cd0. Read the comment docs.

@AVaksman AVaksman marked this pull request as ready for review June 18, 2020 16:24
@AVaksman AVaksman requested a review from skuruppu June 18, 2020 16:59
@skuruppu skuruppu merged commit 39d8f0c into googleapis:master Jun 18, 2020
@skuruppu skuruppu mentioned this pull request Jun 18, 2020
Closed
@AVaksman AVaksman deleted the fix_samples_test branch June 19, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mocha Tests: should read stale data from an example table failed
3 participants
@AVaksman @skuruppu @googlebot