fix: unskip PDML tests when run against emulator #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only skip when running against prod. Also fixed a typo in the query.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 21 21
Lines 20919 20919
Branches 1153 1153
=======================================
Hits 20573 20573
Misses 343 343
Partials 3 3 Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Jun 16, 2020
skuruppu
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also running a previously skipped test against the emulator but still skipping it against prod.