Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support callbacks for exists(), getState(), getExpireTime() methods #1070

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented May 28, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #1070 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          21       21           
  Lines       20423    20448   +25     
  Branches     1096     1096           
=======================================
+ Hits        20069    20094   +25     
  Misses        351      351           
  Partials        3        3           
Impacted Files Coverage Δ
src/backup.ts 99.61% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558692f...e2a3718. Read the comment docs.

@AVaksman AVaksman marked this pull request as ready for review May 28, 2020 22:41
@skuruppu skuruppu self-requested a review May 28, 2020 22:42
@AVaksman AVaksman merged commit 7736080 into googleapis:master Jun 4, 2020
@AVaksman AVaksman deleted the callbackify branch June 19, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants