fix: send the ITimestamp protobuf to Pub/Sub for seeking, not JavaScript Date() #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
feywind
changed the title
JustinBeckwith
approved these changes
Mar 4, 2020
bcoe
approved these changes
Mar 4, 2020
gcf-merge-on-green bot
added a commit
that referenced
this pull request
Mar 4, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.6.0](https://github.com/googleapis/nodejs-pubsub/compare/v1.5.0...v1.6.0) (2020-03-04) ### Features * **subscription:** support oidcToken ([#865](https://github.com/googleapis/nodejs-pubsub/issues/865)) ([a786ca0](https://github.com/googleapis/nodejs-pubsub/commit/a786ca00bd27a6e098125d6b7b87edb11ea6ea0f)) * export protos in src/index.ts ([f32910c](https://github.com/googleapis/nodejs-pubsub/commit/f32910c3a7da5ce268084d7294094912ab696034)) ### Bug Fixes * **deps:** update to the latest google-gax to pull in grpc-js 0.6.18 ([#903](https://github.com/googleapis/nodejs-pubsub/issues/903)) ([78bd9e9](https://github.com/googleapis/nodejs-pubsub/commit/78bd9e97a913b5e2aa457c2a28fd849f67bf225e)) * send the ITimestamp protobuf to Pub/Sub for seeking, not JavaScript Date() ([#908](https://github.com/googleapis/nodejs-pubsub/issues/908)) ([0c1d711](https://github.com/googleapis/nodejs-pubsub/commit/0c1d711854d7397a0fc4d6e84ed090984a6e05dc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
🤖 I have created a release \*beep\* \*boop\* --- ### [3.5.2](https://github.com/googleapis/nodejs-bigtable/compare/v3.5.1...v3.5.2) (2021-06-29) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([googleapis#907](https://github.com/googleapis/nodejs-bigtable/issues/907)) ([cf661df](https://github.com/googleapis/nodejs-bigtable/commit/cf661df12da9dfd02e97d343a2110ce6099891b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the seek() method that prevented users from passing a date correctly. This is especially relevant for purging (seek to the future).
May relate: #905
Related internally: 150712874