Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): bump release level to GA #416

Merged
merged 4 commits into from
Dec 20, 2019
Merged

fix(docs): bump release level to GA #416

merged 4 commits into from
Dec 20, 2019

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2019
@JustinBeckwith JustinBeckwith requested a review from bcoe November 23, 2019 18:07
@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #416 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files           5        5           
  Lines         531      531           
  Branches       52       52           
=======================================
  Hits          518      518           
  Misses         12       12           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6591ff8...3c9e926. Read the comment docs.

@bcoe
Copy link
Contributor

bcoe commented Nov 25, 2019

@soldair before landing the GA label on Bunyan and Winston, I thought it would be good for us to address the race condition you brought up last week that results in an uncaught rejection.

@JustinBeckwith JustinBeckwith added the status: blocked Resolving the issue is dependent on other work. label Nov 25, 2019
@JustinBeckwith
Copy link
Contributor Author

Trying not to lose track of this one. Do we have an issue tracking the aforementioned race condition? @bcoe @soldair

@bcoe
Copy link
Contributor

bcoe commented Dec 16, 2019

@JustinBeckwith googleapis/gcp-metadata#273 I believe I patched the bug @soldair reported in gcp-metadata last week, and it will go out early this week.

@bcoe bcoe removed the status: blocked Resolving the issue is dependent on other work. label Dec 20, 2019
@bcoe bcoe merged commit 4832f31 into master Dec 20, 2019
@bcoe bcoe deleted the ga branch December 20, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants