This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: add fieldMask for getDevice and listDevices #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: cloudiot
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 5 5
Lines 2683 2683
Branches 104 105 +1
=======================================
Hits 2612 2612
Misses 70 70
Partials 1 1 Continue to review full report at Codecov.
|
gcseh
changed the title
telpirion
approved these changes
Feb 4, 2021
samples/manager/manager.js
Outdated
| const [response] = await iotClient.listDevices({parent: parentName}); | ||
| // See full list of device fields: https://cloud.google.com/iot/docs/reference/cloudiot/rest/v1/projects.locations.registries.devices | ||
| // Warning! Use snake_case field names. | ||
| const fieldMask = { paths: [ 'id', 'name', 'num_id', 'credentials', 'last_heartbeat_time', 'last_event_time', 'last_state_time', 'last_config_ack_time', 'last_config_send_time', 'blocked', 'last_error_time', 'last_error_status', 'config', 'state', 'log_level', 'metadata', 'gateway_config' ] }; |
There was a problem hiding this comment.
This is definitely a place where I would break this line up, for example:
const fieldMask = {
paths: [
'id',
'name',
...
]
};
You can probably use prettier to automatically format it for you.
samples/manager/manager.js
Outdated
| const [response] = await iotClient.getDevice({name: devicePath}); | ||
| // See full list of device fields: https://cloud.google.com/iot/docs/reference/cloudiot/rest/v1/projects.locations.registries.devices | ||
| // Warning! Use snake_case field names. | ||
| const fieldMask = { paths: [ 'id', 'name', 'num_id', 'credentials', 'last_heartbeat_time', 'last_event_time', 'last_state_time', 'last_config_ack_time', 'last_config_send_time', 'blocked', 'last_error_time', 'last_error_status', 'config', 'state', 'log_level', 'metadata', 'gateway_config' ] }; |
There was a problem hiding this comment.
Same as above, break into additional lines for readability.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178