This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
fix(types): SessionData was removed from Express type #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
google-cla
bot
added
the
cla: yes
JustinBeckwith
approved these changes
Nov 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 12.63% 12.43% -0.21%
==========================================
Files 3 3
Lines 182 185 +3
==========================================
Hits 23 23
- Misses 159 162 +3
Continue to review full report at Codecov.
|
| @@ -31,7 +31,7 @@ export class DatastoreStore extends expressSession.Store { | |||
| kind: string; | |||
| expirationMs: number; | |||
| constructor(options: DataStoreOptions = {}) { | |||
| super(options); | |||
There was a problem hiding this comment.
Should I not be worried about that?
There was a problem hiding this comment.
Yes, but tests pass ... and I looked at the codebase of express-session and it doesn't use these options as far as I can tell.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [5.0.2](https://github.com/googleapis/nodejs-datastore-session/compare/v5.0.1...v5.0.2) (2020-11-24) ### Bug Fixes * **types:** SessionData was removed from Express type ([#247](https://github.com/googleapis/nodejs-datastore-session/issues/247)) ([33028da](https://github.com/googleapis/nodejs-datastore-session/commit/33028da1b48b88258c7c146dce55149698d5c0cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the nightly synth failures, as well as #246
Fixes #246