Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

samples tests are disabled for this repository #441

Closed
alexander-fenster opened this issue Sep 20, 2022 · 1 comment
Closed

samples tests are disabled for this repository #441

alexander-fenster opened this issue Sep 20, 2022 · 1 comment
Labels
api: containeranalysis Issues related to the googleapis/nodejs-containeranalysis API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alexander-fenster
Copy link
Contributor

The current samples tests depend on the sequence of invocation: the resource is being created in the first test, used in the next test, then deleted in a separate test. This organization of tests leads to flaky tests and is error-prone. Samples tests should be redesigned so that the tests could be executed independently (so that skipping one test wouldn't cause failure of subsequent tests).

For now, I'm disabling all samples tests in #440.
@alexander-fenster alexander-fenster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 20, 2022
@product-auto-label product-auto-label bot added api: containeranalysis Issues related to the googleapis/nodejs-containeranalysis API. samples Issues that are directly related to samples. labels Sep 20, 2022
@NimJay NimJay mentioned this issue Nov 15, 2022
Closed
@NimJay
Copy link

NimJay commented Nov 15, 2022

Since we've migrated the samples from this repo to github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/container-analysis/snippets, I have moved this GitHub issue to GoogleCloudPlatform/nodejs-docs-samples#2851.

@NimJay NimJay closed this as completed Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: containeranalysis Issues related to the googleapis/nodejs-containeranalysis API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-fenster @NimJay